Code Reviews

Jonathan Stanton, Software Engineer, Convoy

Jonathan shares his journey to discovering the value of code reviews. He includes helpful advice for all parties in a code review system: authors, reviewers, and leaders. He covers: • What’s the goal of a code review • How to review another’s code • How to prepare your code to be reviewed by others. • Don’t be a jerk

Ryan Greenberg, Sr. Staff Software Engineer, Slack

A Twitter engineer shares advice for getting people to review your code: discuss code changes beforehand, make them small, and describe them clearly.

Angie Jones, Principal Developer Advocate, Applitools

Angie discusses how code review feedback can often lack thoughtfulness, and how to take it in stride.

Michael Lynch, Software Engineer, Google

Michael explains what is a code review and why are they hard, and then covers 8 techniques for how to do them well: Let computers do the boring parts; Settle style arguments with a style guide; Start reviewing immediately; Start high level and work your way down; Be generous with code examples; Never say “you”; Frame feedback as requests, not commands; Tie notes to principles, not opinions

Google, Editorial Team, Google

In Google's internal documentation for code reviews, they tell code reviewers to look for: design, functionality, complexity, tests, naming, comments, style, consistency, documentation, every line, context, & good things

Kevin London, Software Development Engineer II, Amazon

Kevin covers: • What I look for during a review: architecture / design, style, testing • Review your own code first • How to handle code reviews • On mindset • Addressing suggested changes

Amy Ciavolino, Engineering Manager, Kickstarter

Amy offers some tips for both code reviewers and authors on practicing mindful communication to maximize the teaching and learning value of code reviews.

GitLab, Editorial Team, GitLab

Gitlab's code review guidelines for GitLab team members and wider community members to ensure code is effective, understandable, maintainable, and secure.

Jonathan Maltz, Software Engineer, Yelp

Yelp's code review goals, guidelines and checklists.

Glen D Sanford, Software Engineer, Slack

Glen emphasizes that code review should be the top priority for all team members, and offers advice to reviewers and submitters.

Michaela Greiler, Software Engineer, Microsoft

An in-depth, quantitative study on the effectiveness of code reviews.