What You'll Learn
Intro to Code Reviews
Guidance for the Code Author
- Writing pull requests your coworkers might enjoy reading
A Twitter engineer shares advice for getting people to review your code: discuss code changes beforehand, make them small, and describe them clearly.
Guidance for the Code Reviewer
- How to Do Code Reviews Like a Human (Part One)
Michael explains what is a code review and why are they hard, and then covers 8 techniques for how to do them well: Let computers do the boring parts; Settle style arguments with a style guide; Start reviewing immediately; Start high level and work your way down; Be generous with code examples; Never say “you”; Frame feedback as requests, not commands; Tie notes to principles, not opinions
- What to look for in a code review
In Google's internal documentation for code reviews, they cover these categories of what to look for: Design, Functionality, Complexity, Tests, Naming, Comments, Style, Consistency, Documentation, Every Line, Context, & Good Things
- A Guide to Mindful Communication in Code Reviews
Amy offers some tips for both code reviewers and authors on practicing mindful communication to maximize the teaching and learning value of code reviews.
Example Code Review Policies